pucherot / Pi.Alert

WIFI / LAN intruder detector. Check the devices connected and alert you with unknown devices. It also warns of the disconnection of "always connected" devices
GNU General Public License v3.0
2.03k stars 126 forks source link

Vendor database no longer updates #150

Open b-m-e opened 2 years ago

b-m-e commented 2 years ago

The script to update vendors database from ieee creates zero-length files.

Reason seems to be that ieee moved the files and created a redirect that curl per default does not follow. Solution is to add flag -L to curl.

So in ~/pialert/back/update_vendors.sh

Change lines 27-37 to:

sudo curl -L $1 -# -O http://standards-oui.ieee.org/iab/iab.csv
sudo curl -L $1 -# -O http://standards-oui.ieee.org/iab/iab.txt

sudo curl -L $1 -# -O http://standards-oui.ieee.org/oui28/mam.csv
sudo curl -L $1 -# -O http://standards-oui.ieee.org/oui28/mam.txt

sudo curl -L $1 -# -O http://standards-oui.ieee.org/oui36/oui36.csv
sudo curl -L $1 -# -O http://standards-oui.ieee.org/oui36/oui36.txt

sudo curl -L $1 -# -O http://standards-oui.ieee.org/oui/oui.csv
sudo curl -L $1 -# -O http://standards-oui.ieee.org/oui/oui.txt
ch-ris commented 2 years ago

I would actually recommend using proper https links instead.

iamenderst commented 2 years ago

sed -i 's/http:/https:/' ~/pialert/back/update_vendors.sh

AubreyKloppers commented 2 years ago

Thank you - Adding https to the url did the job 100%! Only thing is, I see that when you do an upgrade it gets overwritten...

FerC10110 commented 2 years ago

"Download Public Listing" links broken

https://standards.ieee.org/products-programs/regauth/

FerC10110 commented 2 years ago

"Download Public Listing" links broken

https://standards.ieee.org/products-programs/regauth/

or blocked my ip

ogghi commented 2 years ago

Seems not working here either. But in the current update_vendors.sh they work? https://standards-oui.ieee.org/iab/iab.csv

dougie23fresh commented 1 year ago

Please update the curl links to use -LO to follow redirections

sudo curl $1 -# -LO http://standards-oui.ieee.org/iab/iab.csv sudo curl $1 -# -LO http://standards-oui.ieee.org/iab/iab.txt

sudo curl $1 -# -LO http://standards-oui.ieee.org/oui28/mam.csv sudo curl $1 -# -LO http://standards-oui.ieee.org/oui28/mam.txt

sudo curl $1 -# -LO http://standards-oui.ieee.org/oui36/oui36.csv sudo curl $1 -# -LO http://standards-oui.ieee.org/oui36/oui36.txt

sudo curl $1 -# -LO http://standards-oui.ieee.org/oui/oui.csv sudo curl $1 -# -LO http://standards-oui.ieee.org/oui/oui.txt

https://askubuntu.com/questions/1036484/curl-o-stores-an-empty-file-though-wget-works-well

reneknuvers commented 1 year ago

Last comment works. But I think it would be better to reference the https-links here:

sudo curl $1 -# -LO https://standards-oui.ieee.org/iab/iab.csv
sudo curl $1 -# -LO https://standards-oui.ieee.org/iab/iab.txt

sudo curl $1 -# -LO https://standards-oui.ieee.org/oui28/mam.csv
sudo curl $1 -# -LO https://standards-oui.ieee.org/oui28/mam.txt

sudo curl $1 -# -LO https://standards-oui.ieee.org/oui36/oui36.csv
sudo curl $1 -# -LO https://standards-oui.ieee.org/oui36/oui36.txt

sudo curl $1 -# -LO https://standards-oui.ieee.org/oui/oui.csv
sudo curl $1 -# -LO https://standards-oui.ieee.org/oui/oui.txt
jokob-sk commented 1 year ago

If you want to have things fixed or added, you should switch to one of the forks. The main project has not been maintained for over 2 years. For example: https://github.com/leiweibau/Pi.Alert https://github.com/jokob-sk/Pi.Alert