search

pucrs-automated-planning / pddl-parser

:snake: Classical Planning in Python
GNU General Public License v3.0
84 stars 23 forks source link

FEATURE: Beefed up :types parsing to include type hierarchies. #5

Closed bcorfman closed 3 years ago

bcorfman commented 3 years ago

I kept my changes focused on only the :types parsing this time.

Maumagnaguagno commented 3 years ago

I guess the conflicts are happening due to my comments fix. I am reviewing the PR now.

Maumagnaguagno commented 3 years ago

Now you can fix the conflicts yourself and accept my suggestions or we can merge like this and I make the suggested changes myself. Once you fix the conflicts we can do either one. Note that I never had a conflict before, not sure how hard it is to fix it.

bcorfman commented 3 years ago

I made the changes you suggested.

Maumagnaguagno commented 3 years ago

Once Travis CI goes green I will merge (it may take a while). Since we are already here and you opened a PR to a project without a License, I assume you are OK giving us permission to use your code until we pick a License. I am thinking about using GPLv3 here, need to read a little bit more about it. Thanks for the PR.

bcorfman commented 3 years ago

That's fine. I don't mind whatever license you want to use. I've checked out other projects like Pyperplan and the planner that's in AIMA-Python, and I don't find them intuitive like this code is. I'm just happy to contribute to the code and continue to make it better if I can.

meneguzzi commented 3 years ago

Thanks @bcorfman for your contributions, and my apologies for just delegating to @Maumagnaguagno (for which I also owe a huge thanks for working on this project with us). I've also been busy with my family at this time.