puddly / android-otp-extractor

Extracts OTP tokens from rooted Android devices
GNU General Public License v3.0
242 stars 22 forks source link

Avoid exceptions for accounts without a name #16

Closed paour closed 6 years ago

paour commented 6 years ago

These were probably generated by an older version of Google Authenticator on my device.

puddly commented 6 years ago

Thanks for the bug report. Can you check if the email column contains a valid name? It could be that the account you imported into Google Authenticator just did not have a name and Authenticator never set one. In that case, I think populating the account name from the email column as a fallback might be a better solution

puddly commented 6 years ago

Thanks.

paour commented 6 years ago

Indeed, the email column contains better data, I've pushed a commit that makes use of it. Since this new commit essentially reverts the previous one, feel free to merge squash. Oops, you were faster :-)

paour commented 6 years ago

And thank you for a very useful tool! And a very nice hack :-)