search

puddly / android-otp-extractor

Extracts OTP tokens from rooted Android devices
GNU General Public License v3.0
242 stars 22 forks source link

Remove account_type from MS Authenticator to fix exporting corporate accounts #29

Closed TheRealPSV closed 5 years ago

TheRealPSV commented 5 years ago

This removes the account_type filter from the Microsoft Authenticator search to fix an issue when exporting corporate tokens which aren't always of type 0

puddly commented 5 years ago

What other values can account_type hold for corporate tokens? I seem to recall there being a reason I filtered out non-zero values, but unfortunately I never documented it.

TheRealPSV commented 5 years ago

In my case, I found a value of 2. Extracting it and putting the backup into andotp did give me the very same values as the MS Authenticator did.

On Fri, Jun 28, 2019, 23:51 puddly notifications@github.com wrote:

What other values can account_type hold for corporate tokens? I seem to recall there being a reason I filtered out non-zero values, but unfortunately I never documented it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/puddly/android-otp-extractor/pull/29?email_source=notifications&email_token=ABRC4UXVGSBSQJAWETFGS3DP43L4LA5CNFSM4H4JAXQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY3QVIY#issuecomment-506923683, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRC4UUKUUCGTRYBNX2ZUDTP43L4LANCNFSM4H4JAXQQ .

puddly commented 5 years ago

If you don't see anything strange after removing the WHERE clause, I think it's good enough to merge. Thanks!