search

pudo / dataset

Easy-to-use data handling for SQL data stores with support for implicit table creation, bulk loading, and transactions.
https://dataset.readthedocs.org/
MIT License
4.76k stars 297 forks source link

Add SQLite url builder #387

Closed kapily closed 2 years ago

kapily commented 2 years ago

Add a method to help build a URL for opening SQLite databases

pudo commented 2 years ago

Heya! Thanks for the PR. I wonder if this utility may be better situated in dataset.util, and not as a classmethod on Database? The method doesn't seem to interact with any other aspect of the class, and we could also import it in __init__.py so that it's easy to pull in as from dataset import make_sqlite_url.

Could you perhaps also add a docstring that describes what the function does and what the arguments do?

kapily commented 2 years ago

@pudo - good point, done!