pudo / dataset

Easy-to-use data handling for SQL data stores with support for implicit table creation, bulk loading, and transactions.
https://dataset.readthedocs.org/
MIT License
4.76k stars 297 forks source link

"primary_increment" arg in database.get_table() #391

Closed vladiscripts closed 2 years ago

vladiscripts commented 2 years ago

db.get_table('table', primary_id='tid', primary_increment=False) raise: TypeError: get_table() got an unexpected keyword argument 'primary_increment'

In the dataset.database.py we see:

    def get_table(self, table_name, primary_id=None, primary_type=None):
        """Load or create a table.

        This is now the same as ``create_table``.

And here the defination of create_table():

    def create_table(
        self, table_name, primary_id=None, primary_type=None, primary_increment=None
    )

As we can see, get_table() does not have not the primary_increment argument, so it is not "the same as create_table.