search

puemos / hls-downloader

Web Extension for sniffing and downloading HTTP Live streams (HLS)
https://puemos.gitbook.io/hls-downloader/
MIT License
1.88k stars 232 forks source link

Firefox error: addon appears corrupt #327

Open xanda-escuyer opened 5 months ago

xanda-escuyer commented 5 months ago

Describe the bug The addon will not install to FireFox. Applies to package archive from GitHub and built from source.

Screenshots Screenshot from 2024-04-07 17-31-15

Desktop (please complete the following information):

Additional context the build instructions might also need changing as the command sh ./build.sh fails with:-

$: ./build.sh 
sh: 0: cannot open ./scripts/clean.sh: No such file
sh: 0: cannot open ./scripts/build-core.sh: No such file
sh: 0: cannot open ./scripts/build-design-system.sh: No such file
sh: 0: cannot open ./scripts/build-extension.sh: No such file
    zip warning: name not matched: ./dist/.

zip error: Nothing to do! (try: zip -r extension-archive.zip . -i ./dist/.)

This was corrected instead by running from the top directory: `sh scripts/build.sh

`Build log attached: build.log

puemos commented 5 months ago

FYI crx is now available in v4.0.1

xanda-escuyer commented 5 months ago

Screenshot from 2024-04-10 19-40-50

This applies to both the release package and when built from source.