search

puetzp / prometheus-http-query

Prometheus HTTP API client
MIT License
14 stars 7 forks source link

Latest Thanos Update breaks the library #15

Open jan-kantert opened 15 hours ago

jan-kantert commented 15 hours ago

We use this library to query thanos. Recent versions added a new entry to the json response:

{
  "status": "success",
  "data": {
    "resultType": "vector",
    "result": [
      {
        "metric": {},
        "value": [
          1733333548.697,
          "0"
        ]
      }
    ],
    "stats": {
      "samples": {
        "totalQueryableSamples": 63,
        "totalQueryableSamplesPerStep": null,
        "peakSamples": 18
      }
    },
    "analysis": {
      "name": "",
      "executionTime": "0s",
      "children": null
    }
  },
  "warnings": [
    "PromQL info: metric might not be a counter, name does not end in _total/_sum/_count/_bucket: \"nginx_ingress_controller_requests\""
  ]
}

This results in this error inside the library:

failed to parse JSON response from server
jan-kantert commented 12 hours ago

This starts with thanos v0.37.0 which merged https://github.com/thanos-io/thanos/pull/7852. prometheus-http-query expects a timing field: Error: missing field "timings".