pufferffish / wireproxy

Wireguard client that exposes itself as a socks5 proxy
ISC License
4.1k stars 235 forks source link

"interface address subnet should be /32 for IPv4 and /128 for IPv6" #82

Closed JohanAR closed 10 months ago

JohanAR commented 10 months ago

Is this check correct? The wireguard conf file that I've received from my VPN provider has subnets /24 for IPv4 and /64 for IPv6, and it works without issues with wg-quick.

In addition, the example wg.conf on ArchWiki also uses /24 and /64.

edit: I tried commenting out this line in config.go and everything seems to work with my VPN conf file.

kubrickfr commented 10 months ago

I think it should work either way, this check is probably not necessary. For a single client (as opposed to a router), /32 or 128 makes "more sense" though, but in the end it should not matter.

JohanAR commented 10 months ago

Thanks! If wireproxy would be made more permissive, should this check be changed to something else, or could it be removed entirely?

kubrickfr commented 10 months ago

I think it could be removed entirely, what do you think @pufferffish ?

LittleVulpix commented 10 months ago

@pufferffish , I know this may be asking a lot, but this one is actually a big help for my current setup. Would it be possible to release/build the binaries including this fix? I'm on windows and so I'm not exactly sure how I'd go around compiling or cross-compiling this.... I would be really grateful.

Thank you very much.

kubrickfr commented 10 months ago

@LittleVulpix you really shouldn't need a new build. Just choose your IP and sticka /32 at the end of it. It should work just the same.