search

pufferpanel / pufferd

The PufferPanel daemon
https://pufferd.pufferpanel.com
Apache License 2.0
46 stars 15 forks source link

Sponge-Vanilla server failing to stop/execute console commands #36

Closed GoadingGoat closed 7 years ago

GoadingGoat commented 7 years ago

https://paste.ee/p/5hhjP

Sponge server fails to stop, yet pufferd says it has.

Pufferpanel returns:

sponge failed stop

EDIT: this also affects running commands on the console, of which there is no temporary fix, as it appears the javascript code is stripping the escape characters.

GoadingGoat commented 7 years ago

A temporary fix for this is to change the "stop" command to "stop\n"

It looks like pufferd is missing the LF on commands. (If i haven't failed at reading golang code) https://github.com/PufferPanel/pufferd/blob/master/environments/standard.go line 92 - _, err = io.WriteString(stdIn, cmd+"\r") and also looks like the same code is in tty.go

although i am not sure if adding it would cause issues for other servers or the environments.

GoadingGoat commented 7 years ago

This relates specifically to sponge vanilla, and I have opened an issue on sponge-vanilla for this. https://github.com/SpongePowered/SpongeVanilla/issues/322

Hopefully they fix it...

Leaving this open till it's resolved in case anyone else is searching for why there sponge-vanilla server is misbehaving.