search

pufferpanel / templates

PufferPanel server templates. These templates are importable via the PufferPanel web interface.
Apache License 2.0
84 stars 140 forks source link

Bump Minecraft Default Java Version Value to 21 (Ensure Compatibility with 1.20.5+) [PUFFERPANEL'S TEMURIN DOCKER IMAGE NEEDS UPDATE TO SUPPORT JDK 21 FIRST, unless it uses the original Temurin image?] #273

Closed Minionguyjpro closed 6 months ago

Minionguyjpro commented 6 months ago

This PR bumps the default Java version value for all Minecraft Java templates to Java 21, in order to increase compatibility by default. Because of this the user doesn't need to tinker, and it is required by 1.20.5 and newer. Newer Java versions work better with older Minecraft versions (doesn't refuse) than newer Minecraft versions do with older Java versions (always refuses if the minimum isn't being met). But the Eclipse Temurin Docker image by PufferPanel should first be updated in order to support Java 21. (I'd love to make some changes but it seems that the Docker image doesn't have a public source which you can contribute to, or well I saw the runtime images but I'm not completely sure about that and it are only a few small changes I think). Or does it use the original Temurin image? Since it doesn't specify a username. Specifying Java 21 already right now on the original system (non-Docker) (even though not default) completely works fine.

Minionguyjpro commented 6 months ago

Whoops, IT'S NOT DONE YET! I see that some things still need to be changed first!

Minionguyjpro commented 6 months ago

Okay, everything should be fixed now. I made small changes to one mod so it's right again (since I checked and the names changed and the old versions weren't available anymore, so that's why). I also fixed that some things were containing '17' but should've not changed to '21' (I've used a sed pattern on Linux to change it from 17 to 21 for every file containing 'minecraft' in the name, it's great but it had also changed a few values that should've not been changed). I've fixed the incorrect parts as they should be, and now it should be good to go as soon as the template also gets a Java 21 version released.

LordRalex commented 6 months ago

https://github.com/pufferpanel/runtime-images is the correct repo that we use for the images that require "some" customization. Otherwise, using eclipse-temurim directly is okay.

I just bumped that to include 21 in it's pipeline.