search

puffinsoft / jscanify

Open-source Javascript mobile document scanner.
https://puffinsoft.github.io/jscanify/
MIT License
956 stars 52 forks source link

Issue: Round Corners #2

Closed TheCre8r closed 1 year ago

TheCre8r commented 1 year ago

It does not work well with pages with round corners. Otherwise works well.

ColonelParrot commented 1 year ago

Hello! Thanks for the report :) Unfortunately, I'm very swamped at the moment, so patches will be very slowly released (unless someone opens a PR, which I would happily accept).

I'm working on fixing this issue. It would be very helpful if you could provide some sample data (no pressure if you can't). It would speed this process up greatly.

ColonelParrot commented 1 year ago

Hey there, Upon closer inspection, I've decided to close this as wontfix as I can't reproduce this issue. If you could send an image containing a document with rounded corners that fails at detection, then I'll be happy to reopen this issue.

Also, I do have to weigh the benefits of detecting this over sacrificing accuracy of regular detection.

TheCre8r commented 1 year ago

Sorry I have been extremely busy lately. This eBay listing shows some good examples of the cards I have that have round corners. https://www.ebay.com/itm/224056497141