search

puffnfresh / roy

Small functional language that compiles to JavaScript.
http://roy.brianmckenna.org/
MIT License
834 stars 74 forks source link

Fix errors from enabling more jshint options #190

Closed puffnfresh closed 11 years ago

puffnfresh commented 11 years ago

Just looking at the JSHint options. Chuck the following under grunt.initConfig:

jshint: {
    options: {
        //onevar: true,
        es3: true,
        indent: 4,
        noarg: true,
        node: true,
        trailing: true,
        undef: true,
        unused: true
    }
}

At the moment, looks like there's a few potential global leakages. We definitely don't want that.

I'm also proposing we use onevar soon. Just to enforce a style.

jedws commented 11 years ago

indent 2 surely? :-)

cheers, jed.

On 30/07/2013, at 8:53 AM, Brian McKenna notifications@github.com wrote:

Just looking at the JSHint options. Chuck the following under grunt.initConfig:

jshint: { options: { //onevar: true, es3: true, indent: 4, noarg: true, node: true, trailing: true, undef: true, unused: true } } At the moment, looks like there's a few potential global leakages. We definitely don't want that.

I'm also proposing we use onevar soon. Just to enforce a style.

— Reply to this email directly or view it on GitHub.