pufmat / skillsmod

A Minecraft mod that adds a fully configurable skill system to the game.
Other
36 stars 10 forks source link

Failure to apply modded attributes from playerEX #26

Open LunarNox opened 1 year ago

LunarNox commented 1 year ago

as in comment. recieve message

Expected a valid player attribute at `attribute` at `data` at index 0 at `rewards` at `evasion+10%` at `categories\combat\definitions.json`
Expected a valid player attribute at `attribute` at `data` at index 0 at `rewards` at `rangedcriticalchance+10%` at `categories\combat\definitions.json`
Expected a valid player attribute at `attribute` at `data` at index 0 at `rewards` at `rangedcriticaldamage+15%` at `categories\combat\definitions.json`

heres the code, the attribute names are correct

    "rangedcriticalchance+10%":{
        "title":"+10% Ranged Crit Chance",
        "icon": {
            "type": "item",
            "data": {
                "item": "spectral_arrow"
            }
        },
        "rewards": [
            {
                "type": "puffish_skills:attribute",
                "data": {
                    "attribute": "playerex:ranged_crit_chance",
                    "value": 0.1,
                    "operation": "multiply_total"
                }
            }
        ]
    },
    "rangedcriticaldamage+15%":{
        "title":"+15% Ranged Crit Damage",
        "icon": {
            "type": "item",
            "data": {
                "item": "crossbow"
            }
        },
        "rewards": [
            {
                "type": "puffish_skills:attribute",
                "data": {
                    "attribute": "playerex:ranged_crit_damage",
                    "value": 0.15,
                    "operation": "multiply_total"
                }
            }
        ]
    },
    "evasion+10%":{
        "title":"+10% Evasion",
        "icon": {
            "type": "item",
            "data": {
                "item": "crossbow"
            }
        },
        "rewards": [
            {
                "type": "puffish_skills:attribute",
                "data": {
                    "attribute": "playerex:evasion",
                    "value": 0.15,
                    "operation": "multiply_total"
                }
            }
        ]
    }
pufmat commented 1 year ago

Attributes from PlayerEX doesn't work because they are registered differently. I'll leave this issue open because I try to find a workaround.