pufmat / skillsmod

A Minecraft mod that adds a fully configurable skill system to the game.
Other
36 stars 10 forks source link

Survival Reimagined Overrides Stamina Attribute #43

Open RobertHDPotatoes opened 11 months ago

RobertHDPotatoes commented 11 months ago

Minecraft Version: 1.16.5 Forge - 36.2.39

Mods + Mod Versions: appleskin-forge-mc1.16.x-2.4.0 InsaneLib-1.4.2-mc1.16.5 puffish_skills-0.5.0-1.16.5-forge IguanaTweaksReborn-2.8.5-mc1.16.5

Survival Reimagined (formerly known as IguanaTweaksReborn) fiddles with the exhaustion system and has config options to increase exhaustion based on a flat multiplier as well as block breaking. When Survival Reimagined is installed alongside Pufferfish's Skills, it nullifies any changes that the stamina attribute should do, and appleskin helps to display this bug the best. I have tried disabling the changes Survival Reimagined makes in its config, but it doesn't fix the conflict.

To replicate the issue, install the above four mods, load into a world, run around and observe the default speed at which exhaustion accumulates. Then, use the command "/attribute @p puffish_skills:player.stamina base set 12", run around again and watch as exhaustion levels simply tick down the same as before. The default behavior with Survival Reimagined not installed, with stamina set to 12, is that the saturation stops when the full hunger bar has the gray background for a prolonged period of time. The effect becomes more obvious the higher the stamina attribute is supposed to be.

RobertHDPotatoes commented 11 months ago

Can confirm this same bug still exists in 1.19.4 (Forge Version 45.2.0) with the same setup, although in 1.19.4 Survival Reimagined has a lot more dependencies.

pufmat commented 11 months ago

Pufferfish's Skills implements stamina attribute by modifying vanilla hunger mechanics, while Survival Reimagined completely overrides hunger mechanics. The only way to make stamina attribute work it to disable Health Regen module in Survival Reimagined.