pug-more / mageploy

An experimental module to replicate Admin actions between different project environments
Open Software License 3.0
99 stars 18 forks source link

Executed list should be stored in Database #16

Closed amenk closed 9 years ago

amenk commented 9 years ago

The changes Mageploy trackst do effect the database. So the executed list should be in the database instead of a file. Reason: If I reimport the database, the tasks should be executed again.

amenk commented 9 years ago

What do you think about my commit? I am using the timestamp as a identifier to track whether an action was executed. Maybe we should generate another unique identifier.

aleron75 commented 9 years ago

I used timestamp in files because I assumed different environments use different file system locations. If we can assume the same for DB (different environments use different DBs) using a timestamp should be ok. About your commit: I didn't tested it so far, reading code it sounds good.

amenk commented 9 years ago

I don't fully get what you are writing. My motivation to store the done-List in Database is that we often import a fresh database and I want the tasks to be executed then.

aleron75 commented 9 years ago

Hi @amenk, your motivation sounds good, you did well.

amenk commented 9 years ago

Thanks. I think I will clean/remove file-storage for the done list

aleron75 commented 9 years ago

We can close the issue as soon as we decide whether to create a branch not to cause backwards compatibility issues. What do you think about it?

amenk commented 9 years ago

I would opt for creating a dev-2.0 branch

aleron75 commented 9 years ago

I would opt for creating a dev-2.0 branch

good, can you create the branch and make the pull request?

amenk commented 9 years ago

I think I can only make a PR to an existing branch

aleron75 commented 9 years ago

just created the "dev-2.0" branch, let me know if there are any issues sincerely, Alessandro

aleron75 commented 9 years ago

Merged and tested on dev-2.0 branch thus I close this issue.