search

pug-php / pug-symfony

Pug (Jade) template engine for Symfony
MIT License
44 stars 3 forks source link

Refactoring tests #20

Closed carusogabriel closed 7 years ago

carusogabriel commented 7 years ago

I've refactored some tests using assertFileExists and assertFileNotExists. Also, removed unnecessary alias for PHPUnit_Framework_TestCase.

I bump PHPUnit version to ^4.8.35, that support the PHPUnit\Framework\TestCase namespace.

codecov-io commented 7 years ago

Codecov Report

Merging #20 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #20   +/-   ##
=========================================
  Coverage     99.25%   99.25%           
  Complexity      120      120           
=========================================
  Files             4        4           
  Lines           401      401           
=========================================
  Hits            398      398           
  Misses            3        3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5675d5e...f7c46de. Read the comment docs.

kylekatarnls commented 7 years ago

Hum, something goes wrong with TravisCI, I get No tests executed! I have to inspect.

kylekatarnls commented 7 years ago

As soom as TravisCI issue https://github.com/travis-ci/travis-ci/issues/8807 will be fixed and build would succeed, I will merge this.

kylekatarnls commented 7 years ago

I found the package that introduced the breaking change php-file-iterator: https://github.com/sebastianbergmann/php-file-iterator/issues/37

I downgrade this package for now and rebase your branch.

kylekatarnls commented 7 years ago

Hi, we still have a problem with the versions 3.0 and 3.1 of Symfony because it uses \PHPUnit_Framework_TestCase: https://github.com/symfony/symfony/blob/v3.0.9/src/Symfony/Bundle/FrameworkBundle/Test/KernelTestCase.php

So we cannot remove this part: https://github.com/pug-php/pug-symfony/pull/20/files#diff-10eafd8bf5fbdde867b86fe38d30b9bb

But maybe the comment // PHPUnit compatibility should rather be // Symfony 3.0 and 3.1 compatibility

kylekatarnls commented 7 years ago

Done. I pulled your branch directly in the master: https://github.com/pug-php/pug-symfony/commit/3e66ebf871cefc23af0ef816e1800b15ed769774

Thanks.