search

pug-php / pug-symfony

Pug (Jade) template engine for Symfony
MIT License
44 stars 3 forks source link

Allow Symfony 5 #44

Closed kylekatarnls closed 4 years ago

kylekatarnls commented 5 years ago

Fix #39 Fix #41

codecov[bot] commented 5 years ago

Codecov Report

Merging #44 into master will decrease coverage by 8.53%. The diff coverage is 69.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #44      +/-   ##
===========================================
- Coverage     98.74%   90.2%   -8.54%     
- Complexity      191     242      +51     
===========================================
  Files             8      12       +4     
  Lines           478     582     +104     
===========================================
+ Hits            472     525      +53     
- Misses            6      57      +51
Impacted Files Coverage Δ Complexity Δ
...Jade/JadeSymfonyBundle/Command/PugAwareCommand.php 0% <0%> (ø) 1 <1> (?)
...JadeSymfonyBundle/Command/AssetsPublishCommand.php 100% <100%> (ø) 14 <0> (+1) :arrow_up:
src/Jade/Exceptions/ReservedVariable.php 100% <100%> (ø) 1 <1> (?)
...rc/Jade/Symfony/Traits/PrivatePropertyAccessor.php 100% <100%> (ø) 1 <1> (?)
src/Jade/Symfony/Traits/Filters.php 100% <100%> (ø) 3 <0> (ø) :arrow_down:
src/Jade/Symfony/MixedLoader.php 100% <100%> (+66.66%) 0 <0> (ø) :arrow_down:
src/Jade/Symfony/Traits/Installer.php 91.7% <15%> (-8.3%) 71 <4> (+6)
src/Jade/Symfony/Traits/Options.php 83.33% <71.42%> (-16.67%) 7 <1> (+1)
src/Jade/Symfony/Traits/HelpersHandler.php 90.51% <72.5%> (-9.49%) 58 <16> (+14)
src/Jade/JadeSymfonyEngine.php 87.77% <75.29%> (-12.23%) 77 <37> (+20)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e92778a...03420ca. Read the comment docs.

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit d72382a5 and detected 145 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 13
Style 21
Bug Risk 95
Clarity 16

Note: there are 85 critical issues.

The test coverage on the diff in this pull request is 68.7% (80% is the threshold).

This pull request will bring the total coverage in the repository to 89.9% (-10.0% change).

View more on Code Climate.