J5lx
commented
7 years ago For reference, this is the relevant PHP that JsPhpize trips over (in my actual, non-MWE project) (if that helps at all):
array_merge(\Jade\Compiler::withMixinAttributes(array (
'name' => 'site',
'required' => true,
), array (
0 =>
array (
'name' => 'name',
'value' => 'site',
'escaped' => true,
),
1 =>
array (
'name' => 'required',
'value' => true,
'escaped' => true,
),
)), (isset($attributes)) ? $attributes : array())
kylekatarnls
MWE:
Expected result:
Actual result:
Apparent cause:
Jade\Compiler\MixinVisitor::visitMixinCall() first passes the attributes to Jade\Compiler\MixinVisitor::parseMixinAttributes() to generate PHP code from them. This PHP code is then later merged with $arguments and passed to Jade\Compiler::createStatements(), where it is further passed down to Jade\Compiler\ExpressionCompiler::getArgumentExpression(). This function then checks for the value of the expressionLanguage option, and since it is set to JS, it tries to convert all arguments, including the generated PHP code, from JavaScript to PHP. And there you have it: The converter trips over PHP’s Paamayim Nekudotayim.
To solve the issue, there would obviously need to be a way to prevent the compiler from trying to convert the PHP code to PHP. It seems to me that ExpressionCompiler::getPhpCodeFromJs() already does this for some array and isset calls, but I'm not quite sure I understand the logic behind those regexes correctly.