pug-php / pug

Pug template engine for PHP
https://www.phug-lang.com
MIT License
391 stars 42 forks source link

Write template locals to json file #150

Closed hustlahusky closed 7 years ago

hustlahusky commented 7 years ago

Hello

I faced with RuntimeException error when my locals object getting so big. And I'm find out that my very large obj argument passed directly to cli. So I added localsJsonFile option that write locals to json file and pass it as obj argument.

codecov-io commented 7 years ago

Codecov Report

Merging #150 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #150      +/-   ##
============================================
+ Coverage     99.92%   99.92%   +<.01%     
- Complexity      991      995       +4     
============================================
  Files            61       61              
  Lines          2829     2842      +13     
============================================
+ Hits           2827     2840      +13     
  Misses            2        2
Impacted Files Coverage Δ Complexity Δ
src/Jade/Engine/Options.php 100% <ø> (ø) 8 <0> (ø) :arrow_down:
src/Jade/Engine/PugJsEngine.php 98.38% <100%> (+0.18%) 29 <0> (+4) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18dfa36...79c2550. Read the comment docs.

kylekatarnls commented 7 years ago

Thanks a lot, your option is available at the version 2.6.5.

hustlahusky commented 7 years ago

still 2.6.4 at packagist :(

kylekatarnls commented 7 years ago

It's usually very fast to update, I put a manual update.