pughpugh / react-countdown-clock

HTML5 canvas countdown clock React component
ISC License
187 stars 83 forks source link

when re render ReactCountdownClock with initial seconds value the counter counts fast #35

Closed jonimin closed 6 years ago

jonimin commented 7 years ago

hi i'm using your lovely counter for a trivia game, in my game logic when user hit on answer i re render the component and set the seconds with initial value, the component re render but the timer start count down much faster, in the 4 quis 10 seconds count down with real value of 3 secends

can you please check it? Thanks Yoni

pughpugh commented 7 years ago

Hi. You'd have to provide a specific code example of it not working as expected. It does sound a little similar to #17 though. Thanks.

jonimin commented 7 years ago

Hi I don't have it deployed no where, I will check 17 and update you

Thanks for getting back to me Yoni

On Friday, September 8, 2017, Hugh Gallagher notifications@github.com wrote:

Hi. You'd have to provide a specific code example of it not working as expected. It does sound a little similar to #17 https://github.com/pughpugh/react-countdown-clock/issues/17 though. Thanks.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pughpugh/react-countdown-clock/issues/35#issuecomment-328115698, or mute the thread https://github.com/notifications/unsubscribe-auth/AY-879X38JQMIwitaPKM-bnLvti4uTXWks5sgUzLgaJpZM4PQmQM .

--

Yoni Adi

minutemedia.com http://www.minutemedia.com/ • 90min.com http://www.90min.com/ • 12up.com http://www.12up.com/

Mobile: +972-5 <%2B972-50-4429315>4-5751687

-- CONFIDENTIALITY NOTICE: This message, including any attachments, is the property of Sportority Group of companies, its affiliates and/or subsidiaries and/or its Brands Minute Media, 90min and 12up, is solely for the use of the individual or entity intended to receive it. It may contain confidential, proprietary and/or privileged information, and any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient or if you have received this message in error, please permanently delete it and contact the sender by reply e-mail.

pughpugh commented 6 years ago

I suspect this is fixed in 2.1.0. If this is still a problem for you, please let me know.

jonimin commented 6 years ago

Thanks I will check it, I’m just about to start new project and I need a timer

בתאריך יום ו׳, 22 בדצמ׳ 2017 ב-16:52 מאת Hugh Gallagher < notifications@github.com>:

Closed #35 https://github.com/pughpugh/react-countdown-clock/issues/35.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pughpugh/react-countdown-clock/issues/35#event-1399702939, or mute the thread https://github.com/notifications/unsubscribe-auth/AY-87yx_Qz2h7d_d_U__usLbqlH_mwAIks5tC8ImgaJpZM4PQmQM .

--

Yoni Adi

CMS & Commercial

minutemedia.com http://www.minutemedia.com/ • 90min.com http://www.90min.com/ • 12up.com http://www.12up.com/

Skype: Joni adi

Mobile: +972-5 <javascript:void(0);>4-5751687

-- CONFIDENTIALITY NOTICE: This message, including any attachments, is the property of Sportority Group of companies, its affiliates and/or subsidiaries and/or its Brands Minute Media, 90min and 12up, is solely for the use of the individual or entity intended to receive it. It may contain confidential, proprietary and/or privileged information, and any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient or if you have received this message in error, please permanently delete it and contact the sender by reply e-mail.