pugjs / babel-plugin-transform-react-pug

A plugin for transpiling pug templates to jsx
MIT License
808 stars 46 forks source link

start server with errors #129

Open jiangyh1024 opened 3 years ago

jiangyh1024 commented 3 years ago

image

not sure why

ezhlobo commented 3 years ago

@jiangyh1024 yeah, I've just upgraded to the latest react-scripts and got the same issue. When I added DISABLE_NEW_JSX_TRANSFORM=true it started working for a while but then died again with absolutely the same issue.

I'm investigating right now

ezhlobo commented 3 years ago

JFYI, I reproduced the issue after upgrading all the dependencies.

Assuming we need to drop node 6 and 8 support and upgrade major version of this plugin, I believe this fix should be coupled with that release, thus it's fine to upgrade internal dependencies here.

ezhlobo commented 3 years ago

Well, it turned out to be an issue in babel itself. Look at the issue and related PR: https://github.com/babel/babel/issues/12478

I think we should wait for new patch version of babel plugins, but in the meantime you can just specify older version of @babel/plugin-transform-react-jsx.

This is what I did for my project:

"devDependencies": {
  "@babel/plugin-transform-react-jsx": ">= 7.12 < 7.12.10 || > 7.12.10"
}

CC @jiangyh1024

jiangyh1024 commented 3 years ago

Thanks , appreciate it very much

发自我的iPhone

在 2020年12月13日,下午8:00,Eugene Zhlobo notifications@github.com 写道:

 Well, it turned out to be an issue in babel itself. Look at the issue and related PR: babel/babel#12478

I think we should wait for new patch version of babel plugins, but in the meantime you can just specify older version of @babel/plugin-transform-react-jsx.

This is what I did for my project:

"devDependencies": { "@babel/plugin-transform-react-jsx": ">= 7.12 < 7.12.10 || > 7.12.10" } CC @jiangyh1024

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

skotchpine commented 3 years ago

the babel issue looks resolved now