pugjs / pug-lint

An unopinionated and configurable linter and style checker for Pug
ISC License
228 stars 51 forks source link

Update outdated dependencies #109

Closed robbyoconnor closed 8 years ago

robbyoconnor commented 8 years ago

minimatch had a vulnerability; acorn was outdated.

Ran the tests and nothing broke.

codecov-io commented 8 years ago

Current coverage is 100% (diff: 100%)

Merging #109 into master will not change coverage

@@           master   #109   diff @@
====================================
  Files          49     49          
  Lines         915    915          
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
  Hits          915    915          
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update 1485947...dbf5258

TimothyGu commented 8 years ago

While at it, would you mind updating the devDependencies as well? Thanks!

robbyoconnor commented 8 years ago

@TimothyGu Done.

rob at rob-LAPTOP in ~/pug-lint (update-outdated-dependencies)
$ david                           
All dependencies up to date
robbyoconnor commented 8 years ago

Broke the build...

robbyoconnor commented 8 years ago

Okay -- so some devDependencies need to be updated with care

robbyoconnor commented 8 years ago

@TimothyGu updating the devDependencies will break the tests. I think the changes I made are more important as one of them is vulnerability :smile:

I'm not in the mood to dive into the code as this was just an itch :)

TimothyGu commented 8 years ago

Okay, that's alright (I'll fix it). Thanks again.