search

pugjs / pug-lint

An unopinionated and configurable linter and style checker for Pug
ISC License
228 stars 51 forks source link

Fix problem with extending scoped config packages #147

Closed jonatanpedersen closed 5 years ago

jonatanpedersen commented 6 years ago

Fixes problem with extending @scoped config packages like @myscope/pug-lint-config-myconfig.

The only way to extend a scoped config package at the moment is to write out the path relative to cwd:

{
  "extends": "./node_modules/@myscope/pug-lint-config-myconfig/index.js"
}

This fix allows extending config like this:

{
  "extends": "@myscope/pug-lint-config-myconfig"
}
jonatanpedersen commented 5 years ago

For this pull requests cake day all it wishes for is to be merged 🎂

adrienverge commented 5 years ago

:+1:

jonatanpedersen commented 5 years ago

Haha, nice one 😀 thanks

brianhelba commented 5 years ago

@adrienverge Can we please get a release on npm, to make this fix available to users?

adrienverge commented 5 years ago

pug-lint 2.6.0 was just published. Can you report whether it's working well or not? Thanks!

brianhelba commented 5 years ago

@adrienverge This works properly for us: https://github.com/girder/girder/pull/3085 . Thanks!