Closed lehni closed 5 years ago
The tests pass on Node 6, but fail on the older versions because the dependency docco
uses the spread operator. That's not an error in this PR, but probably means that the supported and tested Node versions should change.
Hi @lehni,
Is there any backward-incompatibility? Can it break some projects build/lint chain?
@adrienverge well it passes the full test suite, so I don't think so. The only thing that's different that I found was that Pug 2 doesn't consider this invalid markup anymore:
div
|
div
And it shouldn't be:
<div></div><div></div>
just like this:
div
| text
div
now produces:
<div></div>text<div></div>
@adrienverge could you please mention people whose review is required here? Will be nice to have it merged :).
@ezhlobo given the lack of activity here, I'd say that any member's approval will be enough.
It seems like we are 3 to think it's a good changes, so let's merge.
Great, thanks!
Relates to #148, but makes unit tests pass again by adjusting code for internal pug changes: