search

pugjs / pug-lint

An unopinionated and configurable linter and style checker for Pug
ISC License
228 stars 51 forks source link

Update the NodeJS version to test #162

Closed mikemill closed 5 years ago

mikemill commented 5 years ago

The versions are so far behind that 3 of them are failing. Update them to NodeJS 11

codecov-io commented 5 years ago

Codecov Report

Merging #162 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          51       51           
  Lines         942      942           
=======================================
  Hits          941      941           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a31333...3f7c41b. Read the comment docs.

ezhlobo commented 5 years ago

@mikemill why did you decide to close your PR? I wonder because I'd like to make similar changes soon. The only thing is that I'd use node versions from pugjs/pug repository:

https://github.com/pugjs/pug/blob/1f770d63ea12daf7eb1d83e8561fc4bb82df120b/.travis.yml#L2-L6