pugjs / pug-lint

An unopinionated and configurable linter and style checker for Pug

ISC License

228 stars 51 forks source link

Allow ellipsis in attribute names #166

Closed ezhlobo closed 5 years ago

ezhlobo commented 5 years ago

Some time back pug-lexer got an improvement, it started supporting ellipsis in attribute names. Related pull request: https://github.com/pugjs/pug/pull/3152

As pug-lint relies on pug-lexer it makes sense to upgrade it as well.

In addition I added test case to catch the issue in the future.

codecov-io commented 5 years ago

Codecov Report

Merging #166 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          51       51           
  Lines         942      942           
=======================================
  Hits          941      941           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de14b7f...35b0b2a. Read the comment docs.

ezhlobo commented 5 years ago

@pugjs/linter guys, do you think we can get it merged?

adrienverge commented 5 years ago

Looks good to me. Anyone against this?

ezhlobo commented 5 years ago

@adrienverge since nobody has expressed any objection, what if we deliver that as is?

Or would you like to wait until at least one more maintainer responded? If so, maybe let's directly ping them again?

adrienverge commented 5 years ago

Let's merge!