search

pugjs / pug-lint

An unopinionated and configurable linter and style checker for Pug
ISC License
228 stars 51 forks source link

Update README.md #69

Closed ilyakam closed 6 years ago

ilyakam commented 8 years ago

Change link to gulp-pug-linter

I humbly ask to point to my project gulp-pug-linter in this project's README file. It is objectively better because a) it accepts all of the config files that are supported by pug-lint and b) it has an option to break the CI build on lint errors. In addition, it comes with 100% code coverage and is currently under active development.

I've used commit f602190 as a template for my commit message above. Feel free revise it as you see fit.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 54cf643b3509e09344d032d15bc9508fa638641d on ilyakam:feature/update-readme into 915942a65203c80855fe1cf3908a55decf6812e0 on pugjs:master.

benedfit commented 8 years ago

Thanks for this, but I'm going to hold off from merging this just yet. Instead, it would be great if you, @jzsfkzm and @blacksonic could have a chat and maybe try and pool your talents into one tool in order to make it easier for Gulp users to find the best plugin. However, if that doesn't work out, I'd be willing to link to both in the README

jzsfkzm commented 8 years ago

@benedfit afaik I'd happily drop gulp-pug-lint in favor of gulp-pug-linter, except for one thing. We have a lot of projects at Emarsys, all trying to use the same pug-lint config. We achieved this by creating an npm package called pug-lint-config-emarsys and gulp-pug-lint is capable of reading config from that dependency. We created it because we liked how eslint is capable of reading config from an external source.

How about if we added this ability directly to pug-lint, for everyone's advantage? Shall I?

benedfit commented 8 years ago

@jzsfkzm that's a great idea. I've created #79 to add this feature. I've got some time today to take a look at adding this, but if I need a hand I'll give you a shout

benedfit commented 8 years ago

@jzsfkzm extends is now available by default in v2.2

cc @ilyakam

jwalton commented 7 years ago

I see I've made this more complicated: https://github.com/pugjs/pug-lint/pull/139 :P

adrienverge commented 6 years ago

I'd like to merge this: gulp-pug-linter seems well maintained and retro-compatible with old config files.

@jzsfkzm OK for you?

(See https://github.com/pugjs/pug-lint/pull/139#issuecomment-341492101)

ilyakam commented 6 years ago

Hi @adrienverge, it has been nearly two years since I've opened this PR and exactly five months since the decision to merge it has been made. I think @jzsfkzm had plenty of time to chime in by this point.

Is it finally time to merge this PR now?

adrienverge commented 6 years ago

Sure. Let's merge it!