search

pugjs / pug-lint

An unopinionated and configurable linter and style checker for Pug
ISC License
228 stars 51 forks source link

Updated concatenationRegex #76

Closed gcmznt closed 8 years ago

gcmznt commented 8 years ago

Fix regex to exclude js concatenation in attributes

See examples in this link: https://regex101.com/r/kJ7zM4/2

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 97a137698fc2105579ab1852693077658b241e4e on giacomozinetti:patch-1 into ce361db170228f1055d332fd8571010c9021c647 on pugjs:master.

benedfit commented 8 years ago

Thanks, but you mind adding an extra test case that illustrates why this changes is needed?

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 7f3bcfaa185bde8af79ca37b1c2b9cb2788e1fc1 on giacomozinetti:patch-1 into ce361db170228f1055d332fd8571010c9021c647 on pugjs:master.

gcmznt commented 8 years ago

I've added 2 test cases.

benedfit commented 8 years ago

Thanks, however, I've broken your change with some recent work I've done on the regex to improve the column number reported by this test. Do you mind taking another look?

Cheers