search

pugjs / pug-runtime

The runtime for the Pug compiler
MIT License
10 stars 6 forks source link

Fix browserifying build.js #20

Closed TimothyGu closed 9 years ago

alubbe commented 9 years ago

Will fs be an empty object when it is not available, i.e., are we certain we don't have to check the existence of fs itself?

TimothyGu commented 9 years ago

Will fs be an empty object when it is not available, i.e., are we certain we don't have to check the existence of fs itself?

By default, fs is ignored, i.e. require('fs') returns an empty object. If the user changes the browserify setting, this will break, so I guess it's worthwhile to add an additional check.

alubbe commented 9 years ago

LGTM