search

pugjs / pug-runtime

The runtime for the Pug compiler
MIT License
10 stars 6 forks source link

Remove old code #9

Closed alubbe closed 9 years ago

alubbe commented 9 years ago

This removes jade_encode_html_rules, jade_match_html and jade_encode_char. There were deprecated by https://github.com/jadejs/jade-runtime/pull/7 and https://github.com/jadejs/jade-runtime/pull/8. Since they are internal, I believe we should remove them for good.

TimothyGu commented 9 years ago

I'd rather wait until we are comfortable with publishing jade-runtime@2. Although they are internal, they can be accessed by say require('jade-runtime/build')(['encode_html_rules']), so technically it would be an API break if that doesn't work anymore.

ForbesLindesay commented 9 years ago

I'm happy to release 2.0.0 of the runtime straight away. There are some test failures though

alubbe commented 9 years ago

The tests fail because it depends on the new logic of https://github.com/jadejs/jade-runtime/pull/8. If we decide not to merge it, I will adapt this PR to remove only what is safe to remove.

TimothyGu commented 9 years ago

Merged in 766bd47.