pugjs / then-pug

**EXPERIMENTAL** Async promise based Jade
42 stars 5 forks source link

lock version of jade #4

Closed jeromew closed 10 years ago

jeromew commented 10 years ago

Lock the version of jade to the latest released version, rather than master.

We should wait for the next release of jade before doing this

jeromew commented 10 years ago

the then-jade compiler modifications have been updated to match jade 1.3.0. the package.json is now locked on 1.3.0

jeromew commented 10 years ago

@ForbesLindesay this is the last ticket left open do you see something else we could improve ?

Should we wait for a new imminent jade version or is 1.3.0 stable enough according to you for an npm release of then-jade ?

ForbesLindesay commented 10 years ago

I think we're good to go. There will be more releases with more bug fixes soon, but if we waited for jade to be "finished" it would never be released.

Thanks for all your hard work. It's great to see all the tests and docs you've created. The only thing I changed was getting rid of the makefile. It's not needed to just run a few commands in sequence. I also set up the code so that it only downloads jade if it hasn't already downloaded the latest version of jade.

ForbesLindesay commented 10 years ago

2.0.0 is now released :)