fix: platform agnostic react-renderer build process

pugnascotia / spring-react-boilerplate

An example of an isomorphic application using Java + Spring with React, React Router and Redux

MIT License

155 stars 51 forks source link

fix: platform agnostic react-renderer build process #13

Closed jfillo closed 6 years ago

jfillo commented 6 years ago

Fixes the issue reported at: https://github.com/pugnascotia/spring-react-boilerplate/issues/12

I understand this may not be the best way to do file creation/appending in node so feel free to refactor into something a little more readable.

pugnascotia commented 6 years ago

Nice work! I'll merge this in and then see if I can tidy up the new node script. Thanks for your work!

pugnascotia commented 6 years ago

I've reworked the node script in commit 56c1120. Thanks again.

jfillo commented 6 years ago

Np at all. That synchronous writing of the file looks so much better. You may also want to axe the babelrc file, since I don't think thats being used now.6