puhep / pudb

Purdue CMS FPix Database
0 stars 0 forks source link

Need better line colors #116

Closed jstupak closed 8 years ago

jstupak commented 8 years ago

Hello, in the module quality graphs over time, e.g. here: http://www.physics.purdue.edu/cmsfpix/Submission_p/summary/fulltest.php grades A, B, C have too similar colors, please update with something that can be more easily distinguished. Maybe swap with the blue and green from the other two curves.

Thanks, Petra

gneeser commented 8 years ago

I made some changes. How does it look now?

Thanks, Greg

merkelp commented 8 years ago

Hi Greg, it looks good to me now. Thanks!

I noticed that on the same page, the legend in the 'Defects over time' plots should probably be changed from 'bad bumps' to 'bad pixels', since they include also dead pixels etc. This is just so when we show these plots at meetings or reviews we don't give the impression that we have a bump bonding problem.

Thanks, Petra

On 1/4/16 3:52 PM, gneeser wrote:

Petra, I made some changes. How does it look now?

-Greg

— Reply to this email directly or view it on GitHub https://github.com/puhep/pudb/issues/116#issuecomment-168821927.

gneeser commented 8 years ago

Good point, I updated the legend accordingly.