search

puhep / pudb

Purdue CMS FPix Database
0 stars 0 forks source link

Setting 'X Ray Tested' Flag via xml #123

Closed gneeser closed 8 years ago

gneeser commented 8 years ago

I've heard that people have been looking for the ability to set the X Ray Tested post-assembly testing flag through the xml upload. There are two ways I could go about this.

First, I could have the database set the flag any time that x ray results are uploaded, but that would not be negotiable (i.e. you couldn't upload x-ray results and not have the flag changed).

Second, I could require a specific tag, maybe under in the same way we have and the new tag.

Do either of those options sound like what you guys are looking for?

jstupak commented 8 years ago

Making sure @roberts42 and @isando3 see this.

IMO the latter option is better. It gives us flexibility and is not hard to add to the xray upload script. But I'll let the x-ray guys decide

isando3 commented 8 years ago

I agree with John

gneeser commented 8 years ago

Alright, then I'll let you all know when I have that ready.

gneeser commented 8 years ago

I added the check for the new tag. It expects the tag to be (1 for true) and under the tag

gneeser commented 8 years ago

Have you all tested this feature? If it's working, we can close the issue, but if you encounter any problems, let me know.