puhep / pudb

Purdue CMS FPix Database
0 stars 0 forks source link

test by batch page had sudden increase in ungraded modules #187

Closed lantone closed 8 years ago

lantone commented 8 years ago

Maybe you're already aware, but if not, the grades by batch histogram seems to have lost some of the grades:

http://inky.physics.purdue.edu/cmsfpix//Submission_p/graphing/testbybatch_grapher.php

drberry85 commented 8 years ago

It looks like it's not flagging the rejected modules as grade C.

On Fri, Jun 10, 2016 at 2:52 PM, Jamie Antonelli notifications@github.com wrote:

Maybe you're already aware, but if not, the grades by batch histogram seems to have lost some of the grades:

http://inky.physics.purdue.edu/cmsfpix//Submission_p/graphing/testbybatch_grapher.php

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/puhep/pudb/issues/187, or mute the thread https://github.com/notifications/unsubscribe/AElNLLPXAMNbF9Qackda20-B7qnkvVUvks5qKcBzgaJpZM4IzRWe .

gneeser commented 8 years ago

It's probably a mistake I made when trying to optimize the graph load times. I'll look back and see where I went wrong.

lantone commented 8 years ago

good call doug - here's an example i found:

http://inky.physics.purdue.edu/cmsfpix//Submission_p/summary/summaryFull.php?name=M-L-2-41

it's rejected but still showing as Grade : I. I bet it's all the modules that were manually rejected that are affected

gneeser commented 8 years ago

Ah, that tells me where it is in the code. I'll push out a fix over the weekend. Thanks the the sleuthing.

gneeser commented 8 years ago

The grading function is behaving properly again while maintaining the improved runtime. Let me know if you catch any bugs with this though.

-Greg