puhep / pudb

Purdue CMS FPix Database
0 stars 0 forks source link

Run at High Voltage Checkbox #197

Closed gneeser closed 8 years ago

gneeser commented 8 years ago

Add a checkbox next to the completed testing steps checkboxes on the Full Test Submission page to indicate that the module will have to be run at high voltage.

drberry85 commented 8 years ago

Thanks Greg.

On Fri, Aug 12, 2016 at 7:08 PM, gneeser notifications@github.com wrote:

Add a checkbox next to the completed testing steps checkboxes on the Full Test Submission page to indicate that the module will have to be run at high voltage.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/puhep/pudb/issues/197, or mute the thread https://github.com/notifications/unsubscribe-auth/AElNLAasLrdA3POWxrQ6Y4KfeqaDuSSjks5qfQrjgaJpZM4Jjjc- .

drberry85 commented 8 years ago

Hey Greg,

Please don't forget about this. Now that we're processing modules from Purdue, it would be really nice to have this flag. Let me know if there are issues.

Doug

gneeser commented 8 years ago

Doug, I pushed it higher up my to-do list and it turned out to be very quick to add. Let me know if you have any problems with it and I'll be happy to reopen the issue.

-Greg

drberry85 commented 8 years ago

Greg,

Thanks! It looks like it's working.

Doug

On Tue, Aug 16, 2016 at 4:33 PM, gneeser notifications@github.com wrote:

Doug, I pushed it higher up my to-do list and it turned out to be very quick to add. Let me know if you have any problems with it and I'll be happy to reopen the issue.

-Greg

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/puhep/pudb/issues/197#issuecomment-240246371, or mute the thread https://github.com/notifications/unsubscribe-auth/AElNLBItnNRn77Lm-sDE8CdYdTChlu2Uks5qgiy0gaJpZM4Jjjc- .

drberry85 commented 8 years ago

Hey Greg,

Could we add the capability to search for modules that need to be ran at high voltage on the tested module page. Also, and this is very unimportant, could we change the text on the check box from "Run at high voltage" to "Run at -300V". We didn't know what voltage we wanted when we asked for the check box, but now we do.

Doug

gneeser commented 8 years ago

Doug, I added the new filter and updated the text. Let me know if you catch problems.

-Greg