Closed drberry85 closed 7 years ago
At least on the database side, the grade is generated on the fly, so no reprocessing will be necessary and the changes will take effect immediately. I don't know about moreweb though. Does moreweb even grade on the IV?
No, this is just for lessWeb. We can change it in MoReWeb, but that would require us to reprocesses everything, which is a week long adventure at this point.
Doug
On Fri, Aug 19, 2016 at 11:25 AM, gneeser notifications@github.com wrote:
At least on the database side, the grade is generated on the fly, so no reprocessing will be necessary and the changes will take effect immediately. I don't know about moreweb though. Does moreweb even grade on the IV?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/puhep/pudb/issues/198#issuecomment-241065347, or mute the thread https://github.com/notifications/unsubscribe-auth/AElNLBn80ZFxVy71z_FmtHru25Hw8ow-ks5qhdkIgaJpZM4JooeL .
Doug, I updated the IV slope criterion in the dev environment. It definitely seems to have made a difference, as you can see here: http://inky.physics.purdue.edu/cmsfpix//Submission_t/summary/test_list.php?param19=¶m1=¶m20=¶m23=¶m8=¶m27=¶m30=¶m31=¶m34=¶m35=¶m43=¶m22=&comp2=%3D¶m2=C¶m36=¶m42=&comp41=%3D¶m41=&comp3=%3D¶m3=&comp4=%3D¶m4=&comp28=%3D¶m28=&comp10=%3D¶m10=&comp11=%3D¶m11=&comp5=%3D¶m5=&comp7=%3D¶m7=&comp12=%3D¶m12=&comp13=%3D¶m13=&comp37=%3D¶m37=&comp38=%3D¶m38=&comp39=%3D¶m39=&comp40=%3D¶m40=¶m9=&comp25=%3D¶m25=&comp18=¶m18=
(Sorry for the wall of url, that's just how the page handles variables)
Looking at the remaining module that's mounted and still has a grade of C, M-P-3-13, it looks like it is still from the IV, but it just looks like a weird test result, probably not representative of the module. See here: http://inky.physics.purdue.edu/cmsfpix//Submission_t/graphing/xmlgrapher.php?id=3381&scan=IV&level=module
For the 8 modules in Ready for Mounting that are still grade C, only one of them seems to be from the IV - module M-N-3-22, and that also seems like it's just a wonky test result: http://inky.physics.purdue.edu/cmsfpix//Submission_t/graphing/xmlgrapher.php?id=4192&scan=IV&level=module
Based on this, it looks like the relaxed grading criterion works except in edge cases where the test results are just weird. I think that the slope criterion would probably have to be thrown out to grade those cases as anything but C.
Feel free to compare the results to the production environment. If you like what you see, I'll update some of the text to reflect the new criterion and push the changes through.
-Greg
Greg,
I looked at a few modules and it appears fine. The only module that I found that still has a problem is M-Q-A-11. Do you know what the IV ratio is for that module at -20C?
Doug
On Mon, Aug 22, 2016 at 12:41 PM, gneeser notifications@github.com wrote:
Doug, I updated the IV slope criterion in the dev environment. It definitely seems to have made a difference, as you can see here: http://inky.physics.purdue.edu/cmsfpix//Submission_t/ summary/test_list.php?param19=¶m1=¶m20=¶m23=& param8=¶m27=¶m30=¶m31=¶m34=¶m35=& param43=¶m22=&comp2=%3D¶m2=C¶m36=¶m42=& comp41=%3D¶m41=&comp3=%3D¶m3=&comp4=%3D¶m4=& comp28=%3D¶m28=&comp10=%3D¶m10=&comp11=%3D& param11=&comp5=%3D¶m5=&comp7=%3D¶m7=&comp12=%3D& param12=&comp13=%3D¶m13=&comp37=%3D¶m37=&comp38=% 3D¶m38=&comp39=%3D¶m39=&comp40=%3D¶m40=& param9=&comp25=%3D¶m25=&comp18=¶m18=
(Sorry for the wall of url, that's just how the page handles variables)
Looking at the remaining module that's mounted and still has a grade of C, M-P-3-13, it looks like it is still from the IV, but it just looks like a weird test result, probably not representative of the module. See here: http://inky.physics.purdue.edu/cmsfpix//Submission_t/ graphing/xmlgrapher.php?id=3381&scan=IV&level=module
For the 8 modules in Ready for Mounting that are still grade C, only one of them seems to be from the IV - module M-N-3-22, and that also seems like it's just a wonky test result: http://inky.physics.purdue.edu/cmsfpix//Submission_t/ graphing/xmlgrapher.php?id=4192&scan=IV&level=module
Based on this, it looks like the relaxed grading criterion works except in edge cases where the test results are just weird. I think that the slope criterion would probably have to be thrown out to grade those cases as anything but C.
Feel free to compare the results to the production environment. If you like what you see, I'll update some of the text to reflect the new criterion and push the changes through.
-Greg
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/puhep/pudb/issues/198#issuecomment-241490990, or mute the thread https://github.com/notifications/unsubscribe-auth/AElNLGBirRVeoo2KON_ALSiiq-Dgr2Dtks5qid9UgaJpZM4JooeL .
I don't know the exact ratio, but looking at the module's IV here: http://inky.physics.purdue.edu/cmsfpix////Submission_t/graphing/xmlgrapher.php?id=3993&scan=IV&level=module
I think that this is another strange result. I would estimate that the ratio is 5e-9/2e-10, or about 25.
I have to say, it looks like there a large number of abnormalities at low voltage for the -20C results: http://inky.physics.purdue.edu/cmsfpix///Submission_p/graphing/positiongrapher.php?level=fnal&scan=IV&loc=
(note that this is using the old criterion)
Is this an artifact of the low temperature test? I don't see it in the +17C tests, at least not as much: http://inky.physics.purdue.edu/cmsfpix///Submission_p/graphing/positiongrapher.php?level=fnal_17c&scan=IV&loc=
Greg,
Let's apply the change an see how big the effect is. We may still loosen it further or disable it all together.
Doug
On Tue, Aug 23, 2016 at 6:05 PM, gneeser notifications@github.com wrote:
I have to say, it looks like there a large number of abnormalities at low voltage for the -20C results: http://inky.physics.purdue.edu/cmsfpix///Submission_p/ graphing/positiongrapher.php?level=fnal&scan=IV&loc=
(note that this is using the old criterion)
Is this an artifact of the low temperature test? I don't see it in the +17C tests, at least not as much: http://inky.physics.purdue.edu/cmsfpix///Submission_p/ graphing/positiongrapher.php?level=fnal_17c&scan=IV&loc=
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/puhep/pudb/issues/198#issuecomment-241907889, or mute the thread https://github.com/notifications/unsubscribe-auth/AElNLMopQpbavAsJsZx81w26aKu7_Kelks5qi3yegaJpZM4JooeL .
I pushed the change through. Let me know if you catch any places that I missed.
If there are no objections, I'm going to close this issue for now. If you want to make any more changes, feel free to reopen the issue and I'll get on it.
Hey Greg,
Can you loosen the IV slope grade from 2 to 10 [I(V=150)/I(V=100) < 10]? Also, does this require any reprocessing, or will all the grade update automatically.
Doug