Upgrade + Fix broken resolution change

puhitaku / mtplvcap

Nikon to USB Webcam. Supports older models that Nikon WU does not. Windows/macOS/Linux. No HDMI capture dongle is needed. Ask me on Twitter @puhitaku

https://twitter.com/puhitaku

Other

251 stars 17 forks source link

Upgrade + Fix broken resolution change #59

Closed puhitaku closed 2 years ago

puhitaku commented 2 years ago

This PR includes:

Upgrade to Go 1.18
Fix broken resolution change due to a wrong interface{} usage

win0err commented 2 years ago

Tested with Z6: it works fine with --max-resolution. Thanks

puhitaku commented 2 years ago

@win0err So glad to hear that! And thank you for testing it. How many frames-per-seconds and resolution did you get?

win0err commented 2 years ago

Photo Mode: 1024×680, 53-58 fps, ≈35 fps when focusing Video Mode: 1024×576, stable ≈60 fps with AF-C enabled (always focusing)

When I specify the -max-resolution flag, I see the following lines in logs:

[0001]  INFO lv: getting available resolutions
[0001]  INFO lv: available resolutions (higher is larger): [1 2 3]
[0001]  INFO lv: automatically use the largest choice: 3

puhitaku commented 2 years ago

OK, now this patch works for some models at least, so I'm merging & releasing it.