Closed jepperaskdk closed 2 years ago
@puikinsh You can see the built release here: https://github.com/puikinsh/Adminator-admin-dashboard/releases
We should do the same for merge-checks, so we know before merging whether the project builds successfully, and if version has been bumped.
This PR streamlines the release process, so that any push to master triggers this workflow. The workflow uses "version" from package.json to name the release, and creates a tag for it as well. If a tag already exists, it fails since 2 releases have the same version. This makes it difficult to "change" a release, once it has been published. I think it can be solved by manually deleting tag/release, and then pushing the corrected release, which retriggers the workflow.
I also added a step of prebuilding the static assets, with the
npm run build
script. It successfully builds and attaches it to the release, but I'm not sure the built assets are in the correct form since CSS is not extracted, but instead inlined in the JS files with webpack stuff. I think we need to set theprocess.env.NODE_ENV=production
properly (lets create a separate PR for that, or?).We could create both a minified and non-minified ZIP.