search

puikinsh / Adminator-admin-dashboard

Adminator is easy to use and well design admin dashboard template based on Bootstrap 5 for web apps, websites, services and more
https://colorlib.com/polygon/adminator/index.html
MIT License
4.39k stars 1.74k forks source link

Update 404.html #308

Closed JaydeepRokade closed 2 months ago

jepperaskdk commented 2 months ago

@JaydeepRokade Why this change?

JaydeepRokade commented 2 months ago

Because it matches above header tag

On Sat, 31 Aug, 2024, 18:44 jepperaskdk, @.***> wrote:

@JaydeepRokade https://github.com/JaydeepRokade Why this change?

— Reply to this email directly, view it on GitHub https://github.com/puikinsh/Adminator-admin-dashboard/pull/308#issuecomment-2322894167, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDZLHPWNZUOJ277V7ND2AJTZUG6T5AVCNFSM6AAAAABNNWYPZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRSHA4TIMJWG4 . You are receiving this because you were mentioned.Message ID: @.***>

jepperaskdk commented 2 months ago

@JaydeepRokade I don't understand. It looks like a random change serving no purpose. If you make a pull-request to an open-source project, please describe in details why you are making such change. I can see you made a similarly random pull-request to the eslint repository here: https://github.com/eslint/eslint/pull/18776

JaydeepRokade commented 2 months ago

I told you why I have made change still you are asking the above header isn't matching in the project

On Sun, 1 Sept, 2024, 11:31 jepperaskdk, @.***> wrote:

I don't understand. It looks like a random change serving no purpose. If you make a pull-request to an open-source project, please describe in details why you are making such change. I can see you made a similarly random pull-request to the eslint repository here: eslint/eslint#18776 https://github.com/eslint/eslint/pull/18776

— Reply to this email directly, view it on GitHub https://github.com/puikinsh/Adminator-admin-dashboard/pull/308#issuecomment-2323182440, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDZLHPRLTJE565RBUY7AZ4TZUKUSTAVCNFSM6AAAAABNNWYPZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRTGE4DENBUGA . You are receiving this because you were mentioned.Message ID: @.***>

jepperaskdk commented 2 months ago

@JaydeepRokade You need to describe it in more detail.

The error 500 page uses h1 and h3 as well - what do you mean it isn't "matching the project". Please provide some evidence.

JaydeepRokade commented 2 months ago

Ok, I will do that.

On Sun, 1 Sept, 2024, 23:25 jepperaskdk, @.***> wrote:

@JaydeepRokade https://github.com/JaydeepRokade You need to describe it in more detail.

The error 500 page uses h1 and h3 as well - what do you mean it isn't "matching the project". Please provide some evidence.

— Reply to this email directly, view it on GitHub https://github.com/puikinsh/Adminator-admin-dashboard/pull/308#issuecomment-2323441886, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDZLHPV6BGW6JECM4K4JZULZUNIKZAVCNFSM6AAAAABNNWYPZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRTGQ2DCOBYGY . You are receiving this because you were mentioned.Message ID: @.***>