search

puiterwijk / flask-oidc

OpenID Connect support for Flask
BSD 2-Clause "Simplified" License
157 stars 219 forks source link

Itsdangerous replacement with PyJWT #144

Open gerwout opened 2 years ago

gerwout commented 2 years ago

Newer versions of Itsdangerous (i.e. 2.1.1) no longer have support for JWT encoding and/or decoding (https://github.com/pallets/itsdangerous/blob/d1c85670cce70d81f9949619434daf8c0b9cd37e/src/itsdangerous/jws.py#L23-L30). This is a breaking change for flask-oidc. This PR replaces the itsdangerous functionality with PyJWT.

billsteve commented 2 years ago

Very nice.

palewire commented 2 years ago

It would be great to get this merged and released.

jonnydford commented 2 years ago

Is there anything needed to get this PR merged?

tapanhalani commented 2 years ago

If everything looks good, please merge this PR asap. We use flask_oidc (1.4.0) with superset which breaks due to this.

khteh commented 2 years ago

This project / repo needs a new owner.

rvhonorato commented 2 years ago

Any idea when this will be merged? @puiterwijk

gerwout commented 2 years ago

@ecederstrand sorry for my late response, I overlooked your merge request, but I have merged your changes now as well. Would be nice if this PR can now be merged into master

Panagiss commented 2 years ago

@puiterwijk This needs a merge ASAP!

Kalzau commented 2 years ago

@puiterwijk It would be awesome if you could merge this PR :)

benpocklingtonhes commented 1 year ago

@puiterwijk Please can you merge this

christian-hawk commented 1 year ago

We should probably consider this repo unmaintained, fork it and fix it.

zbhuiyan commented 1 year ago

@ramizarif @puiterwijk can we have this merged please?

gautierrog commented 1 year ago

Any chance to see this MR merged?

frozenpandaman commented 1 year ago

Still waiting…