search

pukhalski / tap

1Kb library for easy unified handling of user interactions such as mouse, touch and pointer events.
https://github.com/pukhalski/tap/archive/master.zip
MIT License
527 stars 45 forks source link

VoiceOver #29

Closed leifdejong closed 9 years ago

leifdejong commented 9 years ago

VoiceOver double tap has issue triggering the on tap event action handler.

Running: iPhone 6 - iOS 8.1.2

pukhalski commented 9 years ago

Thanks, @leifdejong. A pretty valuable issue. Never thought about it.

Any ideas so far?

leifdejong commented 9 years ago

@pukhalski Yap so the workaround that I set up was to bind the element to a 'click' as well as a 'tap' and then write some logic to check if it's 'tap', suppress click, otherwise use the click. I have seen this issue on tappy, tap, and hammer. Seems like not a lot of people test VO. My recommendation would be to bind the 'click' when 'tap' is bound and then handle it internally. I will be working on a solution for hammer. Will share my code here once I am through.

ezhlobo commented 9 years ago

Tried to fix it: #30

/cc @leifdejong @pukhalski

leifdejong commented 9 years ago

Looking good so far. Set up a code pen (http://codepen.io/anon/pen/doRpbq) and created a demo pull request (https://github.com/pukhalski/tap/pull/33)

leifdejong commented 9 years ago

VO seems to pick everything up

pukhalski commented 9 years ago

Cool! Gonna merge all PRs then.

leifdejong commented 9 years ago

@pukhalski :+1: