Refactoring - Githubissues

pukhalski / tap

1Kb library for easy unified handling of user interactions such as mouse, touch and pointer events.

MIT License

527 stars 45 forks source link

Closed ezhlobo closed 10 years ago

ezhlobo commented 10 years ago

Changes:

A little bit less code.
If browser doesn’t support touch events there is fallback to click.
I’ve merged 2 files in one.
Small optimisations: create event only once, only one handler for those who work well with clicks.

I think we can disable default action for browsers w/o touch events.

ezhlobo commented 10 years ago

I’ve splitted code on 4 files:

utils - for helpers (we can test this file separately)
events - there is only default device events
tap - library itself
export - move library to global namespace (for changing specific functions in case of need)

Renamed dist directory to build. I think it’s more logic.

ezhlobo commented 10 years ago

All methods and variables of library is private since now. export.js removed.

Renamed build to dist back (it’s more common, see jquery for example).

pukhalski commented 10 years ago

Thanks, @ezhlobo. Reviewed and merged.

Need to add comments there with the next iteration. I can handle it if it's OK for you.