search

pukmajster / funky

Open-source mod manager for Left 4 Dead 2
https://pukmajster.github.io/funky/
MIT License
10 stars 4 forks source link

Mod images are forced stretching #12

Open Nelson0491 opened 2 months ago

Nelson0491 commented 2 months ago

For good-looking purpose, many previews of mods are forced to strech. I noticed that there exists different length-width ratio of mod images. Maybe you can add some conditional statements and take different scaling strategies to improve visual effect.

It's easy to find many of them looking not good, too wide, which also reduce the recognition. Below is an example.

image

pukmajster commented 2 weeks ago

This is what i've come up with so far. Any suggestions, @Nelson0491? image

Nelson0491 commented 2 weeks ago

Thanks for your work! I think turning the filling space to pure black or the same as the background may be better. By the way I find that your length-width ratio strategy is similiar to 16:9, while the workshop takes 1:1 square appearance. Maybe 16:9 is indeed more suitable for the window. 1:1 is just another choice ( or offerring a UI more similiar to workshop? ) Anyway present is completely acceptable. I just offer another possibility.

屏幕截图 2024-10-18 162138 image

MerryDreambound commented 2 weeks ago

Would you be looking for something like this @Nelson0491? I'm not the main dev but the negative I see with this method, is the seemingly wasted space.

(8 mods total example) image

Nelson0491 commented 2 weeks ago

I understand. One solution I come up with is to change to self-adaption width, but that will make the interface not that tidy. Not sure how to balance the space and readability. Because the workshop style also have wasted space, but in vertical direction. However through contrast maybe the workshop one is still a little better. @MerryDreambound

fix

pukmajster commented 2 weeks ago

Here's the blur approach with squares image

pukmajster commented 2 weeks ago

the upcoming v0.4.0 patch already has an "adaptive thumbnail" setting. I can easily modify it so you can choose your preferred aspect ratio, as well has how to fill the wasted space (black, blur or nothing). Sadly it'll never look perfect due to the inconsistency, but I guess having the options is the best we can do, at least for now.

pukmajster commented 2 weeks ago

Update v0.4.0 is out with some new thumbnail settings c: some combinations look bad, but it's a start. Let me know what you think!