search

puku0x / cvdrone

CV Drone (= OpenCV + AR.Drone)
https://github.com/puku0x/cvdrone/wiki/How-to-build
Other
202 stars 94 forks source link

Virtual functions #4

Closed vuki closed 11 years ago

vuki commented 11 years ago

I have one more request. Would you please consider making all public and protected methods in ARDrone class as virtual ones?

I made a class derived from ARDrone and I had to overload the loopVideo method in order to send the video frames to the main program with push method, instead of the pull one you used. I couldn't do it without making this method virtual in ardrone.h.

If it doesn't break your idea of the code, making the methods virtual would add a possibility of writing own code based on ARDrone class without the need to modify the original code each time it is downloaded from github.

Once again, thanks for your work!

puku0x commented 11 years ago

Hi vuki,

Thank you for your advice.

All member functions (except constructor and some static functions) become virtual ones now.

Hope it helps, puku0x

vuki commented 11 years ago

Hello Puku,

Yes, I've already seen the new commits and compiled new code. Everything works fine. Thank you for your very useful software and for changes #3&4, they are very useful for me.

Regards,

Grzegorz Szwoch

puku0x notifications@github.com napisał(a):

Hi vuki,

Thank you for your advice.

All member functions (except constructor and some static functions) become virtual ones now.

Hope it helps, puku0x

— Reply to this email directly or view it on GitHub.