pulb / mailnag

An extensible mail notification daemon
GNU General Public License v2.0
250 stars 32 forks source link

Add GMail feed mode #219

Open dcolascione opened 3 years ago

dcolascione commented 3 years ago

This PR adds a Mailnag backend for using GMail's inbox feed. This method supports GMail accounts for which IMAP support is disabled.

pulb commented 3 years ago

Hey Daniel,

many thanks for this interesting pull request! I'm not very familiar with Gmail RSS, can you elaborate a bit what the advantages over conventional imap gmail are? And is this a Gmail for workgroups only feature or does it work with free Gmail as well?

BR Patrick

Am 3. Februar 2021 21:29:27 MEZ schrieb Daniel Colascione notifications@github.com:

This PR adds a Mailnag backend for using GMail's inbox feed. This method supports GMail accounts for which IMAP support is disabled. You can view, comment on, or merge this pull request online at:

https://github.com/pulb/mailnag/pull/219

-- Commit Summary --

  • Add GMail feed mode

-- File Changes --

A .dir-locals.el (3) M .gitignore (2) M Mailnag/backends/init.py (6) A Mailnag/backends/gmail_rss.py (211) M Mailnag/common/accounts.py (8) M Mailnag/common/config.py (5) M Mailnag/configuration/accountdialog.py (324) M Mailnag/daemon/idlers.py (6) M Mailnag/daemon/mails.py (6) M data/account_widget.ui (365)

-- Patch Links --

https://github.com/pulb/mailnag/pull/219.patch https://github.com/pulb/mailnag/pull/219.diff

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/pulb/mailnag/pull/219

dcolascione commented 3 years ago

Thanks for taking a look!

can you elaborate a bit what the advantages over conventional imap gmail are?

This backend works when IMAP access is turned off. Corporate customers of G Suite can disable IMAP access. Without IMAP access, conventional mailnag backends don't work. This backend gives users access to desktop email notifications even in organizations where IMAP access has been disabled by policy.

And is this a Gmail for workgroups only feature or does it work with free Gmail as well?

The linked documentation (https://developers.google.com/gmail/gmail_inbox_feed) suggests that it's a G-Suite-only feature, but the feed link (https://mail.google.com/mail/u/0/feed/atom) works with my personal account too, so I think the feature is just generally available.

pulb commented 3 years ago

Thanks for the fast reply! I see, so since it uses plain old http to fetch the mails, this also seems to be the solution to some of those firewall/VPN bugreports I got. Awesome, will do an in-depth review as soon as I find time!

Am 4. Februar 2021 18:43:34 MEZ schrieb Daniel Colascione notifications@github.com:

Thanks for taking a look!

can you elaborate a bit what the advantages over conventional imap gmail are?

This backend works when IMAP access is turned off. Corporate customers of G Suite can disable IMAP access. Without IMAP access, conventional mailnag backends don't work. This backend gives users access to desktop email notifications even in organizations where IMAP access has been disabled by policy.

And is this a Gmail for workgroups only feature or does it work with free Gmail as well?

The linked documentation (https://developers.google.com/gmail/gmail_inbox_feed) suggests that it's a G-Suite-only feature, but the feed link (https://mail.google.com/mail/u/0/feed/atom) works with my personal account too, so I think the feature is just generally available.

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/pulb/mailnag/pull/219#issuecomment-773487463

dcolascione commented 3 years ago

Thanks. IMAP access is still preferable though: this mode is read only (no mark as seen), had no push support (so we have to poll), and in my testing reports only the 20 most recent messages. It's better than nothing though