Changelog for v3 - Githubissues

puleos / object-hash

Generate hashes from javascript objects in node and the browser.

MIT License

1.41k stars 145 forks source link

Closed kachkaev closed 9 months ago

kachkaev commented 2 years ago

👋 This issue is a new instance of https://github.com/puleos/object-hash/issues/87. v3.0.0 was released recently but README → Changelog only mentions 2.0.0:

Although it is possible to look at git log and find https://github.com/puleos/object-hash/pull/114, it is probably too much of a detour for such a popular library 🙂

dieseldjango commented 2 years ago

Does v3 break compatibility with hashes?

addaleax commented 2 years ago

Yes, v3.x generates different hashes but is otherwise compatible.

Feel free to open a PR.

JaLe29 commented 2 years ago

@addaleax can you please explain what do you mean by "different hashes"?

// V2
hash({foo: 'bar'}) // => '67b69634f9880a282c14a0f0cb7ba20cf5d677e9'

// V3
hash({foo: 'bar'}) // => 'diferent hash' ????????????

So, sha1 in v2 is not same in v3?

dwelle commented 2 years ago

@JaLe29 check https://github.com/puleos/object-hash/pull/114 — previous version wasn't distinguishing between typed arrays

medikoo commented 2 years ago

It's better not to release a breaking change than to release it with zero (changelog) documentation.