pulgamecanica / slidespeak-coding-challenge-2024

Coding challenge: Build a PowerPoint video extractor 🧑‍💻
0 stars 1 forks source link

File Deletion Optimization and UUID Implementation #5

Open pulgamecanica opened 1 day ago

pulgamecanica commented 1 day ago

💡 Description

The current implementation deletes files twice:

  1. Before using unzip.
  2. After files are uploaded to S3.

This approach may introduce inefficiencies, especially if the same cleanup operation is repeated. Additionally, using temporary file names without unique identifiers could lead to file name conflicts if multiple users upload files with the same name concurrently.


📝 Proposal


🔍 Discussion Points


Tasks (If Accepted)


🎯 Acceptance Criteria

kgoedecke commented 1 day ago

I think you can just use uuid.uuid4() from the default python package import uuid.

pulgamecanica commented 1 day ago

Yeah I agree, I'll implement this.