pulibrary / alma-notices

configurations for notices sent from alma
3 stars 0 forks source link

shipping address incomplete in order notice #188

Closed regineheberlein closed 3 years ago

regineheberlein commented 3 years ago

though other orders have the complete address; following up

regineheberlein commented 3 years ago

Probably caused by Order List letter:

Order Now letter has the shipping address hard-coded; Order List letter is using this prefab code from ExL--looks like the condition (not empty) is failing:

<table border="1px" align="right" width="50%"
                                style="border-collapse: collapse;">
                                <tr style="background-color:#e9e9e9;">
                                    <td>
                                        <b>@@shipping_address@@: </b>
                                    </td>
                                </tr>
                                <tr>
                                    <td>
                                        <xsl:value-of
                                            select="/notification_data/po/ship_to_address/line1"/>
                                    </td>
                                </tr>
                                <xsl:if test="/notification_data/po/ship_to_address/line2[. = '']">
                                    <tr>
                                        <td>
                                            <xsl:value-of
                                                select="/notification_data/po/ship_to_address/line2"
                                            />
                                        </td>
                                    </tr>
                                </xsl:if>
                                <tr>
                                    <td>
                                        <xsl:value-of
                                            select="/notification_data/po/ship_to_address/city"/>
                                    </td>
                                </tr>
                                <tr>
                                    <td>
                                        <xsl:value-of
                                            select="/notification_data/po/ship_to_address/country"/>
                                    </td>
                                </tr>
                            </table>
                        </td>
                    </tr>
                </table>

The corresponding data looks like this:

<ship_to_address><city>Princeton</city>
<country>USA</country>
<country_display>United States</country_display>
<create_date>12/02/2020</create_date>
<entity_action></entity_action>
<library_id></library_id>
<library_unit_id></library_unit_id>
<line1>Princeton University Library</line1>
<line2>One Washington Road</line2>
<line3></line3>
<line4></line4>
<line5></line5>
<note></note>
<originating_id></originating_id>
<postal_code>8544</postal_code>
<preferred>false</preferred>
<segment_types_display><string>Patron Communications</string>
<string>Primary</string>
<string>Billing</string>
<string>Shipping</string>
<string>Research</string>
</segment_types_display>
<state_province>NJ</state_province>
<user_address_types_display></user_address_types_display>
</ship_to_address>
regineheberlein commented 3 years ago

Regardless, the data provided for shipping is not what we want, which is:

Princeton University Library Acquisitions Services-Monographs Princeton University Library 693 Alexander Road Princeton, NJ 08540-6317 USA

Phone: 609-258-3219 FAX: 609-258-0441 E-Mail: orderdiv@princeton.edu

regineheberlein commented 3 years ago

hard-coded the shipping address